feat(trezor): add HF15 support, BP+ #8299

ph4r05 · 2022-04-27T16:58:25Z

HP15 changes implemented to the Trezor client in Monero wallet
BP+ support added for Trezor
old Trezor firmware version support removed, code cleanup

Trezor firmware changes: trezor/trezor-firmware#2232

ph4r05 · 2022-04-28T09:33:37Z

Pinging @sethforprivacy that we have all code ready in PRs to support HF15

sethforprivacy · 2022-04-28T13:06:57Z

Pinging @sethforprivacy that we have all code ready in PRs to support HF15

Wow, that was quick, thank you! Will forward this on and update the checklist.

ph4r05 · 2022-05-26T10:27:11Z

Just pinging that Trezor PRs were merged

sethforprivacy · 2022-05-26T12:42:33Z

Thanks, @ph4r05, I pinged the Monero dev channel that this should be ready for review etc. yesterday, and will be sure we get it in ASAP.

Thank you for all of the hard work on this!

kayabaNerve · 2022-05-28T00:48:36Z

Just to confirm, does the have the inv-8 reversion? #8277 (only merged 17 days ago)

I remember hearing that concern. The only branch with a commit since then (besides a version bump on the same day, present in this branch) is the "hackathon results" which seems to be cleaning up.

Any test on the current master which confirms TXs work would be sufficient to confirm :)

ph4r05 · 2022-05-31T18:58:27Z

@kayabaNerve thats a good point, let me check

ph4r05 · 2022-05-31T19:43:40Z

@kayabaNerve you were right, I've incorporated the #8277 change. Trezor firmware needs the change as well, I will create the PR now.

kayabaNerve · 2022-05-31T20:01:05Z

Thanks, and sorry you're only hearing about this now after Trezor already did a merge. Happy we're catching it though, and thanks again for working on this :)

ph4r05 · 2022-05-31T20:41:18Z

No problem @kayabaNerve! I am glad we caught it before release! :)

ph4r05 · 2022-06-13T19:13:52Z

hello @moneromooo-monero, if you pls find a minute, I would be grateful for PR review for upcoming HF upgrade, thanks a lot! :)

selsta · 2022-06-13T19:38:57Z

We will have a second release before the HF that will include this patch.

selsta · 2022-06-20T14:22:57Z

@ph4r05 Just for completeness, did you test this on the current testnet? Are view tags working correctly in addition to BP+? Also is the firmware already out so that I can test this myself? If not, any approx release date?

ph4r05 · 2022-06-20T14:29:58Z

@selsta

ad testnet - I never test it on testnet. Trezor-tests are passing, they generate a synthetic blockchain, sign several transactions and daemon validates them with full node logic. So PR should work properly (this approach worked perfectly so far)
I have no clue what view tags are - have to look into it more
ad trezor release date: @matejcik

selsta · 2022-06-20T14:32:32Z

View tags: #8061

ph4r05 · 2022-06-20T14:44:18Z

There is definitely no view tags support added in Trezor. I will check it out this week and figure out required changes.

selsta · 2022-06-20T14:49:52Z

I asked @j-berman and he said

16:19 <jberman[m]> AFAICT trezor should be fine because they lean on the default `generate_output_ephemeral_keys` which handles view tags, but I'd need to test to know for sure and I don't have a trezor

but he only took a quick look himself. I think the easiest way would be to make a transaction on testnet, or change the fork height locally and try to construct a transaction.

- BP+ support added for Trezor - old Trezor firmware version support removed, code cleanup

ph4r05 · 2022-06-20T18:04:03Z

thanks @selsta for the ping! I've added view tag support to the trezor firmware: trezor/trezor-firmware#2345. This PR is also updated. As wallet is using view_key to derive view tags, tx receiving code on the wallet side does not require changes.

trezor_tests are passing so I am pretty confident view_tags will work also on testnet / mainnet when HF15 is activated.

selsta · 2022-06-22T18:06:08Z

@matejcik It would be good to have a date for the Trezor firmware release as it's something that has to be done before we hardfork.

The current HF date is 2022-07-16, but we will likely push it back 2 weeks to around 2022-08-01. Is that enough time for Trezor to release a firmware update?

matejcik · 2022-06-27T09:22:39Z

@selsta We will not be releasing firmware sooner than August 17-ish.
Does that mean breakage in the interim?

ph4r05 · 2022-06-27T09:43:39Z

@selsta are pls HF15 changes enforced on activation or is it still possible to send HF14 transactions to the network (normal Bulletproofs) for some time after HF15 activation?

If HF15 rules are enforced, Trezor won't be able to sign new transactions until new trezor-firmware update.

kayabaNerve · 2022-06-27T12:01:51Z

I believe there will be a 24 hour interim period where both transaction types are valid. After those 24 hours, only the new ones will be.

selsta · 2022-06-28T20:57:46Z

@matejcik Would it be possible to split the firmware update in two? One for monero and one for the other planned changes? If not we will have to ask the monero community if they prefer to delay the hardfork or if they are okay with leaving Trezor users unable to transact for about 2 weeks. Both are not ideal :/

matejcik · 2022-06-30T12:36:56Z

@selsta thing is, there are no other planned changes right now .)
but good news is, we considered this and decided to go ahead with July release. So the new firmware should be out by July 20.

matejcik · 2022-07-04T12:39:31Z

Bad news everyone.
We will not be able to do a firmware release this month. The originally announced date, August 17, is back in the game.
I've seen that you pushed back HF activation to August 13, so that is only four days of service disruption.

selsta · 2022-07-06T02:55:32Z

Thank you for the update, four days shouldn't be too bad.

@ph4r05 Is there a way for me to install the firmware before the update is out? A nightly firmware build or something similar? I want to do some additional testing on testnet.

matejcik · 2022-07-08T11:31:21Z

@selsta you should be able to pick a firmware image from our CI
pick a pipeline, the task you're looking for is core fw regular build, then browse the artifacts.
here is latest master build

selsta · 2022-08-03T19:35:49Z

Did some testing with the firmware image from CI, tx creation and receiving worked well on testnet.

selsta · 2022-08-03T19:37:46Z

@ph4r05 please also open against release-v0.18

j-berman

Changes LGTM. I see the majority of this PR's changes get rid of dead code for now unusable versions, thank you :)

The one thing I didn't fully wrap my around is the minimal versioning setting, but I figure you've got it how you want it

j-berman · 2022-08-05T01:44:33Z

src/device_trezor/device_trezor.cpp

-      if (trezor_version <= pack_version(2, 0, 10)){
-        throw exc::TrezorException("Trezor firmware 2.0.10 and lower are not supported. Please update.");
+      if (trezor_version < pack_version(2, 4, 3)){
+        throw exc::TrezorException("Minimal Trezor firmware version is 2.4.3. Please update.");


From these comments:

Another thing, I hard-coded to the monero wallet that firmware version 2.5.1 supports HF15

We are releasing 2.5.1 which does not include this PR. Please bump to 2.5.2 in the monero PR.

I'm assuming only Trezor v2.5.2 will support bp+ and view tags. Wouldn't that mean the minimal Trezor version should be v2.5.2? Is the minimum set at v2.4.3 to support tx construction pre-fork?

Nevermind, I see. Once this ships, Trezors v2.4.3 and up will be able to use updated wallets until the fork height

Thanks for the review @j-berman! That was the idea, so old Trezors could still use the wallet even if they did not update yet. We can later enforce minimal version 2.5.2.

ph4r05 · 2022-08-05T12:29:07Z

@ph4r05 please also open against release-v0.18

Done @selsta: #8299 :)
thanks!

ph4r05 mentioned this pull request Apr 27, 2022

XMR: HP15 support, implement BulletproofPlus, refactor and cleanup trezor/trezor-firmware#2232

Merged

sethforprivacy mentioned this pull request Apr 28, 2022

v15 Network Upgrade Checklist monero-project/meta#690

Closed

79 tasks

ph4r05 force-pushed the pr/001-trezor-hf15 branch from 38c0717 to 1c4cd56 Compare May 10, 2022 14:39

ph4r05 force-pushed the pr/001-trezor-hf15 branch from 1c4cd56 to ee72984 Compare May 31, 2022 19:42

ph4r05 closed this May 31, 2022

ph4r05 reopened this May 31, 2022

ph4r05 mentioned this pull request May 31, 2022

fix(xmr): Remove inv8 optimization as in xmr master trezor/trezor-firmware#2314

Merged

ph4r05 force-pushed the pr/001-trezor-hf15 branch from ee72984 to e621309 Compare May 31, 2022 21:33

feat(trezor): add HF15 support, BP+

a0df140

- BP+ support added for Trezor - old Trezor firmware version support removed, code cleanup

ph4r05 force-pushed the pr/001-trezor-hf15 branch from e621309 to a0df140 Compare June 20, 2022 17:43

ph4r05 mentioned this pull request Jun 20, 2022

fix(xmr): add missing view_tags to hf15 trezor/trezor-firmware#2345

Merged

j-berman approved these changes Aug 5, 2022

View reviewed changes

ph4r05 mentioned this pull request Aug 5, 2022

feat(trezor): add HF15 support, BP+, release-v0.18 #8483

Merged

luigi1111 merged commit 080fc69 into monero-project:master Aug 23, 2022

ph4r05 deleted the pr/001-trezor-hf15 branch March 19, 2023 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(trezor): add HF15 support, BP+ #8299

feat(trezor): add HF15 support, BP+ #8299

ph4r05 commented Apr 27, 2022

ph4r05 commented Apr 28, 2022

sethforprivacy commented Apr 28, 2022

ph4r05 commented May 26, 2022

sethforprivacy commented May 26, 2022

kayabaNerve commented May 28, 2022

ph4r05 commented May 31, 2022

ph4r05 commented May 31, 2022

kayabaNerve commented May 31, 2022

ph4r05 commented May 31, 2022

ph4r05 commented Jun 13, 2022

selsta commented Jun 13, 2022

selsta commented Jun 20, 2022

ph4r05 commented Jun 20, 2022 •

edited

Loading

selsta commented Jun 20, 2022

ph4r05 commented Jun 20, 2022

selsta commented Jun 20, 2022

ph4r05 commented Jun 20, 2022 •

edited

Loading

selsta commented Jun 22, 2022 •

edited

Loading

matejcik commented Jun 27, 2022 •

edited

Loading

ph4r05 commented Jun 27, 2022 •

edited

Loading

kayabaNerve commented Jun 27, 2022

selsta commented Jun 28, 2022

matejcik commented Jun 30, 2022

matejcik commented Jul 4, 2022

selsta commented Jul 6, 2022

matejcik commented Jul 8, 2022

selsta commented Aug 3, 2022

selsta commented Aug 3, 2022

j-berman left a comment

j-berman Aug 5, 2022

j-berman Aug 5, 2022 •

edited

Loading

ph4r05 Aug 5, 2022

ph4r05 commented Aug 5, 2022 •

edited

Loading

feat(trezor): add HF15 support, BP+ #8299

feat(trezor): add HF15 support, BP+ #8299

Conversation

ph4r05 commented Apr 27, 2022

ph4r05 commented Apr 28, 2022

sethforprivacy commented Apr 28, 2022

ph4r05 commented May 26, 2022

sethforprivacy commented May 26, 2022

kayabaNerve commented May 28, 2022

ph4r05 commented May 31, 2022

ph4r05 commented May 31, 2022

kayabaNerve commented May 31, 2022

ph4r05 commented May 31, 2022

ph4r05 commented Jun 13, 2022

selsta commented Jun 13, 2022

selsta commented Jun 20, 2022

ph4r05 commented Jun 20, 2022 • edited Loading

selsta commented Jun 20, 2022

ph4r05 commented Jun 20, 2022

selsta commented Jun 20, 2022

ph4r05 commented Jun 20, 2022 • edited Loading

selsta commented Jun 22, 2022 • edited Loading

matejcik commented Jun 27, 2022 • edited Loading

ph4r05 commented Jun 27, 2022 • edited Loading

kayabaNerve commented Jun 27, 2022

selsta commented Jun 28, 2022

matejcik commented Jun 30, 2022

matejcik commented Jul 4, 2022

selsta commented Jul 6, 2022

matejcik commented Jul 8, 2022

selsta commented Aug 3, 2022

selsta commented Aug 3, 2022

j-berman left a comment

Choose a reason for hiding this comment

j-berman Aug 5, 2022

Choose a reason for hiding this comment

j-berman Aug 5, 2022 • edited Loading

Choose a reason for hiding this comment

ph4r05 Aug 5, 2022

Choose a reason for hiding this comment

ph4r05 commented Aug 5, 2022 • edited Loading

ph4r05 commented Jun 20, 2022 •

edited

Loading

ph4r05 commented Jun 20, 2022 •

edited

Loading

selsta commented Jun 22, 2022 •

edited

Loading

matejcik commented Jun 27, 2022 •

edited

Loading

ph4r05 commented Jun 27, 2022 •

edited

Loading

j-berman Aug 5, 2022 •

edited

Loading

ph4r05 commented Aug 5, 2022 •

edited

Loading