Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptonote core/protocol: don't drop peers for soft offenses #8808

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

jeffro256
Copy link
Contributor

Alternative to #8806, and addresses issue in #8806 (comment). So far it is untested.

@SChernykh
Copy link
Contributor

handle_notify_new_transactions is where you should check m_no_drop_offense too.

@jeffro256 jeffro256 force-pushed the soft_offense branch 2 times, most recently from 8e3af77 to b329999 Compare March 28, 2023 03:23
@jeffro256 jeffro256 marked this pull request as ready for review March 28, 2023 03:28
@moneromooo-monero
Copy link
Collaborator

I would rather this be temporary until the next fork where they can be kicked again.

@jeffro256
Copy link
Contributor Author

This can easily be done by deleting one line in tx_pool.cpp for the broken rule that you want it to drop from now on.

@jeffro256
Copy link
Contributor Author

Like it if you wanted to drop connections for large tx_extra starting today, you would just delete the corresponding tvc.m_no_drop_offense = true; line.

@jeffro256 jeffro256 force-pushed the soft_offense branch 3 times, most recently from c6f56f8 to 88ad4d3 Compare March 29, 2023 00:04
@jeffro256
Copy link
Contributor Author

This is definitely the final version, no more edits.

@SChernykh
Copy link
Contributor

If this replaces #8806 (actually #8807), it must also have the second commit with the ZMQ fix.

Also: txs with tx_extra which is too large will not get published to ZMQ

Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
@plowsof
Copy link
Contributor

plowsof commented Mar 29, 2023

I ran the earlier patch from sech on my node for 24~ hours without connections dropping. I'm now running this with no problems. I ran a quick test using an old node connected to one using this patch as a priority node. began broadcasting ordinals. they did not appear in the mempool of the patched node (nor where they mined by it). ran a sweep_all too , 77 ish transactions with 146in16outs to sanity check a large normal tx and they where broadcast fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants