Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS Arm artifact output #9357

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

preland
Copy link
Contributor

@preland preland commented Jun 9, 2024

This PR edits the depends GitHub Actions workflow to export the macOS Arm artifact alongside the pre-existing x86_64 macOS artifact.

This is an intermediary step for creating universal macOS binaries for monero.

Copy link
Collaborator

@selsta selsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change but I don't see much benefit of universal binaries.

@preland
Copy link
Contributor Author

preland commented Jun 12, 2024

The main benefit of universal binaries is reduced platform dependency on MacOS. While x86 MacOS binaries can be ran on Arm using a translation layer, this does come with some drawbacks in performance, as well as lack of support for newer processor instruction sets (although this may not be an issue for monero currently). This results in downstream Monero projects building for both x86 and Arm separately (see haveno-dex/haveno#843).

@selsta
Copy link
Collaborator

selsta commented Jun 12, 2024

Right, I meant not much benefit for us in monero since we support separate x86 and ARM binaries.

Benefits

  • Having a single Mac binary is easier for end user

Downsides

  • Larger binary size, takes longer to download
  • Difficult to integrate with our reproducible build system

it's not worth it in my opinion

@luigi1111 luigi1111 merged commit 1d40309 into monero-project:master Aug 13, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants