wallet2: move get_rpc_status func to RPC server definition file #9379
+25
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
suggested changes
Jun 25, 2024
| @@ -80,6 +80,19 @@ namespace cryptonote | |||
| #define CORE_RPC_STATUS_NOT_MINING "NOT MINING" | |||
| #define CORE_RPC_STATUS_PAYMENT_REQUIRED "PAYMENT REQUIRED" | |||
|
|
|||
| static inline const std::string get_rpc_status(const bool trusted_daemon, const std::string &s) | |||
There was a problem hiding this comment.
If you drop the static keyword, the linker will merge multiple potential copies in the runtime binary. Otherwise, each compilation unit will have its own copy, and I don't see a good reason for this.
j-berman
force-pushed
the
move-rpc-status-func
branch
from
0fed15d
to
6c28bdb
Compare
vtnerd
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports consistent RPC status handling between wallet2 and a new wallet lib
Used in the Seraphis lib async scanner: UkoeHB#23