Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-4373): bump prebuild install to 7.1.1 #145

Merged
merged 1 commit into from
Jul 1, 2022
Merged

chore(NODE-4373): bump prebuild install to 7.1.1 #145

merged 1 commit into from
Jul 1, 2022

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Jun 30, 2022 •
edited
Loading

Description

What is changing?

Pin to a later prebuild-install version.

prebuild-install  7.0.1  →  7.1.1

What is the motivation for this change?

Remove the chance for the grandchild dependency ansi-regex 2.1.1 from being installed in production.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the relevant portions of the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review June 30, 2022 19:27
@nbbeeken nbbeeken changed the title chore(NODE-4297): bump prebuild install to 7.1.1 chore(NODE-4373): bump prebuild install to 7.1.1 Jun 30, 2022
durran
durran approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing task is failing on master.

@durran durran merged commit 142842f into 2.0 Jul 1, 2022
@durran durran deleted the NODE-4297/ansi-regex-fix branch July 1, 2022 14:31
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran