Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5600): use ubuntu 18 to build and publish #162

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix(NODE-5600): use ubuntu 18 to build and publish #162

merged 1 commit into from
Aug 31, 2023

Conversation

durran
Copy link
Member

@durran durran commented Aug 31, 2023 •
edited
Loading

Description

Reverts build variants back to Ubuntu 18 to build and publish with a lower GLIBC version.

What is changing?

Updates to the Evergreen config to revert some of abaf8d4

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5600

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

addaleax
addaleax approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's compatible with Node 16.

Has nothing to do with Node.js 16 🙂 The distro version is what matters here

@baileympearson baileympearson merged commit c02db0e into main Aug 31, 2023
@baileympearson baileympearson deleted the NODE-5600 branch August 31, 2023 17:30
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @addaleax @baileympearson