Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5746): allow runtime linking against system kerberos library #165

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Nov 8, 2023

E.g. GYP_DEFINES='kerberos_use_rtld=true' npm i --build-from-source can be used to enable this flag.

  • add a CI job that exercises this build config
  • add a CI job to run tests on RHEL8 that would fail without this

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

E.g. `GYP_DEFINES='kerberos_use_rtld=true' npm i --build-from-source`
can be used to enable this flag.
@addaleax addaleax marked this pull request as ready for review November 20, 2023 16:14
@addaleax
Copy link
Contributor Author

Chatted with @dariakp and @baileympearson today, we decided that if adding a RHEL8 test comes with significant complexity, we could drop that requirement here, so this should be ready for review now.

(Unfortunately, the current test setup here seems to be fairly tied to Ubuntu 22.04 as the OS, I couldn’t manage to port it to RHEL/Rocky 8 or to split the test code from the server setup code, nor could I manage to get the mongodb server docker test images that our team maintains to run properly here.)

Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some knowledge share questions for ya, thanks in advance!

src/unix/kerberos_gss.cc Show resolved Hide resolved
binding.gyp Outdated Show resolved Hide resolved
@nbbeeken nbbeeken self-assigned this Nov 20, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 20, 2023
Copy link
Collaborator

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

binding.gyp Outdated Show resolved Hide resolved
src/unix/kerberos_gss.cc Show resolved Hide resolved
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants