-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5746): allow runtime linking against system kerberos library #165
Conversation
E.g. `GYP_DEFINES='kerberos_use_rtld=true' npm i --build-from-source` can be used to enable this flag.
Chatted with @dariakp and @baileympearson today, we decided that if adding a RHEL8 test comes with significant complexity, we could drop that requirement here, so this should be ready for review now. (Unfortunately, the current test setup here seems to be fairly tied to Ubuntu 22.04 as the OS, I couldn’t manage to port it to RHEL/Rocky 8 or to split the test code from the server setup code, nor could I manage to get the mongodb server docker test images that our team maintains to run properly here.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some knowledge share questions for ya, thanks in advance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E.g.
GYP_DEFINES='kerberos_use_rtld=true' npm i --build-from-source
can be used to enable this flag.add a CI job to run tests on RHEL8 that would fail without thisDescription
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript