Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6320): macos runtime linking name conflict with SSL #193

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented Aug 9, 2024

Description

What is changing?

  • Put the macos build back to dynamic linking instead of runtime linking
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • On MacOS, libraries that the kerberos addon tries to load do not exist under the same names. This prevents the addon from loading.

Release Highlight

MacOS builds reverted to use dynamic linking

We recently made runtime linking with system kerberos libraries (#165) the default for Linux and MacOS (#188) platforms due to the fact that system kerberos libraries often link against the system SSL library. However, Node.js ships with it's own SSL library, and having both loaded when they are different versions would crash the addon. Inadvertently this did not work as intended on MacOS, so we're reverting the change for that platform, other platforms are unaffected.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran self-assigned this Aug 12, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants