fix(ObjectID): ObjectId.isValid should check buffer length

mongodb · Nov 2, 2018 · 06af813 · 06af813
1 parent a767fa1
commit 06af813
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/objectid.js b/lib/objectid.js
@@ -328,7 +328,7 @@ class ObjectId {
       return true;
     }
 
-    if (id instanceof _Buffer) {
+    if (id instanceof _Buffer && id.length === 12) {
       return true;
     }
 

diff --git a/test/node/object_id_tests.js b/test/node/object_id_tests.js
@@ -80,4 +80,18 @@ describe('ObjectId', function() {
 
     done();
   });
+
+  /**
+   * @ignore
+   */
+  it('should isValid check input Buffer length', function(done) {
+    var buffTooShort = new Buffer ([]);
+    var buffTooLong = new Buffer([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13]);
+    var buff12Bytes = new Buffer([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]);
+
+    expect(ObjectId.isValid(buffTooShort)).to.be.false;
+    expect(ObjectId.isValid(buffTooLong)).to.be.false;
+    expect(ObjectId.isValid(buff12Bytes)).to.be.true;
+    done();
+  });
 });