Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4887): serializeInto does not check for the presence of a toBSON method for values in Map entries #555

Merged
merged 3 commits into from
Jan 9, 2023
Merged

fix(NODE-4887): serializeInto does not check for the presence of a toBSON method for values in Map entries #555

merged 3 commits into from
Jan 9, 2023

Conversation

W-A-James
Copy link
Contributor

Description

Adding fix to ensure that values of Maps run are replaced by the result of calling their toBSON method if it exists.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Ensure that BSON.serialize keeps with spec behaviour

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests

@W-A-James W-A-James force-pushed the NODE-4887/serializeInto_does_not_check_for_toBSON_method_for_map_entries branch from 6deae7c to 6de6fdb Compare January 6, 2023 21:22
@W-A-James W-A-James marked this pull request as ready for review January 6, 2023 21:26
baileympearson
baileympearson requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small test wording suggestion. I'm requesting changes for visibility but otherwise LGTM

test/node/to_bson_test.js Outdated Show resolved Hide resolved
@W-A-James @baileympearson
test(NODE-4877): Change test name
6f927fa 
Co-authored-by: Bailey Pearson <bailey.pearson@mongodb.com>
@baileympearson baileympearson merged commit ebc1c76 into main Jan 9, 2023
@baileympearson baileympearson deleted the NODE-4887/serializeInto_does_not_check_for_toBSON_method_for_map_entries branch January 9, 2023 20:46
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@W-A-James @baileympearson