GODRIVER-2930 Allow setting batch size for subsequent getMore's on a ChangeStream. #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
force-pushed
the
godriver2930-cs-batch-size
branch
from
19b0e61
to
a9d8a85
Compare
matthewdale
force-pushed
the
godriver2930-cs-batch-size
branch
from
a9d8a85
to
8fc6461
Compare
matthewdale
requested review from
prestonvasquez and
qingyang-hu
and removed request for
a team
prestonvasquez
approved these changes
Aug 2, 2023
qingyang-hu
approved these changes
Aug 2, 2023
matthewdale
added a commit
that referenced
this pull request
Aug 2, 2023
matthewdale
added a commit
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2930
Summary
Allow setting batch size for subsequent
getMores on aChangeStream.Background & Motivation
Currently you can set batch size on a
ChangeStreamusingChangeStreamOptions.SetBatchSize. However, that applies to both the initial "aggregate" command as well as the subsequent "getMore" commands run while iterating the change stream. That can cause a problem when starting a change stream on low- or bursty-traffic collections because the initial aggregate won't return a cursor until the batch size is filled. The tailable cursor used by a change stream is intended to wait indefinitely for updates, but the initial "aggregate" command isn't, so will time out if there aren't enough changes to fill a batch, leading to an unexpected error.