Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3335): do not validate explain verbosity in client #2834

Merged

Conversation

rose-m
Copy link
Contributor

@rose-m rose-m commented Jun 9, 2021

As referenced in NODE-3335 the client should not validate the values of explain verbosity but let the server handle the validation. This PR removes the validation check of the string values (and only verifies whether it's a boolean we can auto-transform or a string).

@rose-m rose-m changed the title fix: do not validate explain verbosity in client NODE-3335 fix(NODE-3335): do not validate explain verbosity in client Jun 9, 2021
@nbbeeken nbbeeken self-requested a review June 9, 2021 17:23
@nbbeeken nbbeeken marked this pull request as draft June 14, 2021 14:50
@nbbeeken nbbeeken marked this pull request as ready for review June 22, 2021 16:15
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
FYI for the team I've made a ticket to backport this: NODE-3377

@nbbeeken nbbeeken added the Team Review Needs review from team label Jun 22, 2021
@nbbeeken nbbeeken merged commit 1a57ba8 into mongodb:4.0 Jun 24, 2021
@rose-m rose-m deleted the NODE-3335-do-not-validate-explain-verbosity branch June 24, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants