feat(NODE-5564): bump bson version to ^5.5.0 #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
changed the title
W-A-James
changed the title
nbbeeken
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Bump bson dependency version to 5.5 to make use of new
Decimal128behaviour.Is there new documentation needed for these changes?
Just release notes
What is the motivation for this change?
NODE-5564
Release Highlight
Bumped
bsonversion to make use of newDecimal128behaviourIn this release, we have adopted the changes made to
Decimal128in bson version 5.5. TheDecimal128constructor andfromString()methods now throw when detecting a loss of precision (more than 34 significant digits). We also expose a newfromStringWithRounding()method which restores the previous rounding behaviour.See the bson v5.5.0 release notes for more information.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript