-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5613): add awaited
field to SDAM heartbeat events
#3895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need the awaited
field on HeartbeatSucceeded and HeartbeatFailed events: https://github.com/mongodb/specifications/blob/master/source/server-discovery-and-monitoring/server-discovery-and-monitoring-logging-and-monitoring.rst#events-api
Good catch. I've updated. |
awaited
field to SDAM heartbeat events
Description
Adds an
awaited
field to server heartbeat events.What is changing?
awaited
field and sets it to true when using the streaming protocol.Is there new documentation needed for these changes?
None
What is the motivation for this change?
Need the field to pass tests coming in NODE-5197
Release Highlight
Server heartbeat events now contain an
awaited
field that istrue
when using the streaming protocol.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript