-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-5749): RTTPinger always sends legacy hello #3921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-5749-rtt-serverApi
branch
from
November 10, 2023 17:32
06af474
to
54c8af6
Compare
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Nov 10, 2023
durran
previously approved these changes
Nov 10, 2023
nbbeeken
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Nov 13, 2023
dariakp
requested changes
Nov 13, 2023
test/integration/connection-monitoring-and-pooling/rtt_pinger.test.ts
Outdated
Show resolved
Hide resolved
test/integration/connection-monitoring-and-pooling/rtt_pinger.test.ts
Outdated
Show resolved
Hide resolved
test/integration/connection-monitoring-and-pooling/rtt_pinger.test.ts
Outdated
Show resolved
Hide resolved
test/integration/connection-monitoring-and-pooling/rtt_pinger.test.ts
Outdated
Show resolved
Hide resolved
dariakp
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Fixes a connection leak when serverApi is enabled.
Release Highlight
Fix connection leak when serverApi is enabled
When enabling serverApi the driver's RTT mesurment logic (used to determine the closest node) still sent the legacy hello command "isMaster" causing the server to return an error. Unfortunately, the error handling logic did not correctly destroy the socket which would cause a leak.
Both sending the correct hello command and the error handling connection clean up logic are fixed in this change.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript