Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5765): change type for countDocuments #3932

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

pashok88895
Copy link
Contributor

@pashok88895 pashok88895 commented Nov 26, 2023

Description

Is this intentional or just a bug?

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

countDocuments now types the filter using the collection Schema

Previously, countDocuments had a weakly typed Document type for the filter allowing any JS object as input. The filter is now typed as Filter<Schema> to enable autocompletion, and, hopefully, catch minor bugs.

Thank you to @pashok88895 for contributing to this improvement.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alenakhineika alenakhineika changed the title fix type for countDocuments fix(NODE-5765): change type for countDocuments Nov 27, 2023
@alenakhineika alenakhineika added tracked-in-jira Ticket filed in MongoDB's Jira system Primary Review In Review with primary reviewer, not yet ready for team's eyes External Submission PR submitted from outside the team Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 28, 2023
@alenakhineika alenakhineika removed the Team Review Needs review from team label Nov 29, 2023
@alenakhineika alenakhineika merged commit 22cae0f into mongodb:main Nov 29, 2023
24 of 26 checks passed
@alenakhineika
Copy link
Contributor

@pashok88895 thank you for contributing! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team tracked-in-jira Ticket filed in MongoDB's Jira system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants