-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update _list.json to add Portuguese from Portugal layouts, both ISO and ANSI (diogozarro) #4795
Conversation
frontend/static/layouts/_list.json
Outdated
"portuguese_pt_qwerty_iso":{ | ||
"keymapShowTopRow": false, | ||
"type": "iso", | ||
"keys": { | ||
"row1": ["\\|", "1!", "2\"", "3#", "4$", "5%", "6&", "7/", "8(", "9)", "0=", "'?", "«»"], | ||
"row2": ["qQ", "wW", "eE", "rR", "tT", "yY", "uU", "iI", "oO", "pP", "+*", "´`"], | ||
"row3": ["aA", "sS", "dD", "fF", "gG", "hH", "jJ", "kK", "lL", "çÇ", "ºª", "~^"], | ||
"row4": ["<>", "zZ", "xX", "cC", "vV", "bB", "nN", "mM", ",;", ".:", "-_"], | ||
"row5": [" "] | ||
} | ||
}, | ||
"portuguese_pt_qwerty_ansi":{ | ||
"keymapShowTopRow": false, | ||
"type": "ansi", | ||
"keys": { | ||
"row1": ["\\|", "1!", "2\"", "3#", "4$", "5%", "6&", "7/", "8(", "9)", "0=", "'?", "<>"], | ||
"row2": ["qQ", "wW", "eE", "rR", "tT", "yY", "uU", "iI", "oO", "pP", "+*", "´`", "~^"], | ||
"row3": ["aA", "sS", "dD", "fF", "gG", "hH", "jJ", "kK", "lL", "çÇ", "ºª"], | ||
"row4": ["zZ", "xX", "cC", "vV", "bB", "nN", "mM", ",;", ".:", "-_"], | ||
"row5": [" "] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to portuguese_qwerty_iso
and portuguese_qwerty_ansi
.
Also please move lower in the file, next to theswedish_qwerty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is more than one Portuguese layout it would be better to keep the "pt" to better distinguish so in the future we could have for instance:
portuguese_pt
portuguese_br
[Portuguese from Portugal] layout is different from [Portuguese from Brazil]:
Do you agree, or should I remove the pt as you suggested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thats fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just move the layouts lower in the file then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/6878255965 |
Thanks |
Description
Added Portuguese from Portugal qwerty layouts, both ISO and ANSI