Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(languages): add Gujarati language support (prince-patel23) #4967

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

prince-patel23
Copy link
Contributor

Description

This PR introduces support for the Gujarati language in Monkeytype. Users can now practice typing in Gujarati.

Checks

  • Adding a language?

    • Edited _list.json, _groups.json, and added languages.json.
  • Checked for related open issues.

  • PR title follows the Conventional Commits standard. (Conventional Commits for more info)

  • GitHub username included in parentheses at the end of the PR title.

Closes #issue-number (if applicable)

BREAKING CHANGE: This commit introduces support for the Gujarati language in Monkeytype. Users can now practice typing in Gujarati.
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Jan 25, 2024
@prince-patel23
Copy link
Contributor Author

prince-patel23 commented Jan 25, 2024

Hi @monkeytypegeorge ,👋

I've added Gujarati language support to Monkeytype #4967 . Following Conventional Commits, all checks are completed.

Could you review and merge when convenient? Happy to address any feedback.

Thanks!
@prince-patel23

This commit adds the "noLazyMode": true property in the Gujarati.json file.
@prince-patel23
Copy link
Contributor Author

Hi @Miodec ,👋

I've implemented the suggested change by adding the "noLazyMode": true property in the Gujarati.json file. All checks are completed, and I believe this change will enhance the Gujarati language support.

Could you please review and consider merging the changes? I appreciate your time!

Thanks!
@prince-patel23

@unrealapex
Copy link
Contributor

Please don't @ people unless you specifically need their attention. GitHub automatically notifies people.

@radar
Copy link
Contributor

radar commented Jan 26, 2024

Yeah why did I get mentioned here? I’m not a maintainer

@Miodec Miodec merged commit d7a8519 into monkeytypegame:master Jan 29, 2024
7 checks passed
@Miodec
Copy link
Member

Miodec commented Jan 29, 2024

Thanks. Be careful about mentioning people for no reason ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants