Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sounds): add fist fight and rubber keys (Absalon43) #4984

Merged
merged 9 commits into from
Feb 8, 2024

Conversation

Absalon43
Copy link
Contributor

Description

Added two new sound fonts

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

@monkeytypegeorge monkeytypegeorge added backend Server stuff frontend User interface or web stuff labels Jan 30, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7715281063

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7718537768

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 1, 2024
@Miodec
Copy link
Member

Miodec commented Feb 5, 2024

There is loads of "empty space" in the new error sound, I would trim it down to make it more responsive.

image

Also, im still unsure about the "plastic toy" name...

@Absalon43
Copy link
Contributor Author

All should be in order now

@Miodec Miodec changed the title feat: add support for fist fight and plastic toy sounds (Absalon43) feat(sounds): add fist fight and rubber keys (Absalon43) Feb 8, 2024
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 78bb715 into monkeytypegame:master Feb 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Server stuff frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants