Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): added anti_hero theme (mizaagi) #5018

Merged
merged 17 commits into from
Feb 26, 2024

Conversation

mizaagi
Copy link
Contributor

@mizaagi mizaagi commented Feb 7, 2024

Description

  • Added anti_hero.css
  • Updated _list.json with anti_hero theme

Screenshot 2024-02-14 143657

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 7, 2024
@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 7, 2024

i should have called this stupid theme dragonfruit and not anti hero :( miodec if u add pls change name :)

@Miodec
Copy link
Member

Miodec commented Feb 8, 2024

You can open the web editor with. and change your file names there, then commit.

@Miodec
Copy link
Member

Miodec commented Feb 8, 2024

But also i would increase the difference between text color and sub color, they blend in a bit.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 8, 2024
@Miodec
Copy link
Member

Miodec commented Feb 8, 2024

Can you send some screenshots from the updated version?

@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 8, 2024

Can you send some screenshots from the updated version?

Added these :)

@Miodec
Copy link
Member

Miodec commented Feb 8, 2024

I would update the text color to be closer to white, and the sub alt color to be closer to the background (darker)

This doesnt look good to me at the moment:
image

@Miodec
Copy link
Member

Miodec commented Feb 8, 2024

image
Also error is unreadable (pro is misspelled here)

@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 8, 2024

@Miodec I fixed everything! Pretty sure that the commits I made updated, but if not then they're definitely on mizaagi:master. Thanks and sorry for the inconvenience!

@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 9, 2024

@Miodec just checking in... sorry for bothering you again but wanted to make sure you knew the theme was all done. thanks

@Miodec
Copy link
Member

Miodec commented Feb 12, 2024

image
image
image

With flip test colors off the errors are still not visible. Difference between main and sub color is not big enough, blends together

@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 12, 2024

K

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7879172029

hopefully the final change to this theme.
hopefully the final change to this theme.
@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 12, 2024

@Miodec Finished another set of changes, hopefully the last. Screenshots have been updated as well as the code of _list.json and anti_hero.css. Sorry for the trouble again and thanks so much for considering my theme!

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7879208677

@Miodec
Copy link
Member

Miodec commented Feb 13, 2024

image

Errors are still invisible

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7885955651

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/7886010576

@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 13, 2024

Dude... I don't know what you mean. I've changed it multiple times. What would the optimal color be? Please send it to me

@Miodec
Copy link
Member

Miodec commented Feb 13, 2024

Well.. something that is actually visible at a glance.

New error color fix
@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 14, 2024

@Miodec fixed the color

Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Feb 22, 2024
@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 25, 2024

Hey @Miodec 🙏🙏🙏

@FFUV
Copy link

FFUV commented Feb 25, 2024

Hey @Miodec 🙏🙏🙏

dw bro I think it will be added in I'd use it myself

@github-actions github-actions bot removed the Stale Has not been updated in a while label Feb 25, 2024
@Miodec Miodec merged commit becb66d into monkeytypegame:master Feb 26, 2024
7 checks passed
@mizaagi
Copy link
Contributor Author

mizaagi commented Feb 27, 2024

Thank you so much!!!!! So happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants