Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pressing space too early with the dark note theme doesnt highlight the word as incorrect (mokshsinghji) #5052

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

mokshsinghji
Copy link
Contributor

Description

A new style is added to change the colour of characters that were missed while doing a typing test.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
      • Screenshot of the change:

msedge_rDud5tkBo8

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #5042

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Feb 14, 2024
@Miodec
Copy link
Member

Miodec commented Feb 14, 2024

I would color the missed characters red to compensate for the missing underline.

EDIT: hmm but then it wil look like these characters were typed..

@fehmer fehmer self-requested a review February 14, 2024 11:39
@Miodec
Copy link
Member

Miodec commented Feb 14, 2024

Nevermind, it looks fine
image

@Miodec Miodec merged commit 24975e5 into monkeytypegame:master Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing space too early with the dark note theme doesnt highlight the word as incorrect
4 participants