Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commandline): prevent theme switch when opening the commanline from the footer (sanidhyas3s) #5163

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

sanidhyas3s
Copy link
Contributor

Description

Prevent preview of 8008 caused when opening the theme menu from the footer.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #5103

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 1, 2024
@Miodec Miodec changed the title fix: Prevent theme switch when opening theme commandline from the footer (sanidhyas3s) fix(commandline): prevent theme switch when opening the commanline from the footer (sanidhyas3s) Mar 1, 2024
Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 4c550c7 into monkeytypegame:master Mar 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the theme name in the footer causes the 8008 theme to be previewed
5 participants