Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show command key tip correctly (fehmer) #5234

Merged
merged 3 commits into from
Mar 23, 2024

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented Mar 15, 2024

Description

Tip on the top of the settings page was not showing tab to open command line if quickRestart=esc.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Mar 15, 2024
Copy link
Contributor

@pasanflo pasanflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8343634787

@fehmer fehmer changed the title fix: show command key tip correctly fix: show command key tip correctly (fehmer) Mar 21, 2024
@Miodec
Copy link
Member

Miodec commented Mar 23, 2024

Thanks

@Miodec Miodec merged commit fc3ac84 into master Mar 23, 2024
6 checks passed
@Miodec Miodec deleted the feature/fix-tip-text-on-settings-page branch March 23, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants