Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Commit

Permalink
Use the new signing features for RealSigning (#10)
Browse files Browse the repository at this point in the history
Context: xamarin/yaml-templates#73

> [xamarin/yaml-templates#73] changes things in that nothing is signed
> and the nuget-signed artifact no longer gets created. In order to
> create that artifact, at least one of he 4 "control" parameters needs
> to be set.  If you have received approval to RealSign, then you can
> add the  `realSign` parameter as well.

The effect is two changes of consequence vs. bce1b7f & 3fa0c2e: 

 1. When NuGet packages are signed, a "real" signing certificate will
    be used, not a "test" signing certificate.  (This was the case
    with Mono.Terminal v5.4.1.)

 2. Builds for all tags and master commits are *no longer* signed.
    Instead, signing is an explicit AzDO operation after the build
    is complete.  This ensures manual review & approval of all
    signed artifacts.
  • Loading branch information
mattleibow authored Oct 28, 2020
1 parent 3fa0c2e commit 5d67d34
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .ci/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ jobs:
- template: sign-artifacts/jobs/v1.yml@internal-templates
parameters:
dependsOn: [ 'build' ]
realSign: true
signTags: true
signMain: true
6 changes: 4 additions & 2 deletions LineEditor/LineEditor.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<PackageId>Mono.Terminal</PackageId>
<PackageVersion>5.4.1</PackageVersion>
<PackageVersion>5.4.2</PackageVersion>
<Authors>Microsoft</Authors>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<PackageIconUrl>https://github.com/mono/LineEditor/raw/master/icon_128x128.png</PackageIconUrl>
<PackageLicenseUrl>https://github.com/mono/LineEditor/blob/master/LICENSE</PackageLicenseUrl>
<Owners>Xamarin</Owners>
<PackageProjectUrl>https://github.com/mono/LineEditor</PackageProjectUrl>
<PackageReleaseNotes>Release 5.4.1 improves Windows support.</PackageReleaseNotes>
<PackageReleaseNotes>Release 5.4.2 improves Windows support.</PackageReleaseNotes>
<PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
<Summary>An interactive commmand line editor</Summary>
<Title>Mono.Terminal - LineEdit, GetLine</Title>
Expand All @@ -24,7 +24,9 @@
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DocumentationFile>bin\Debug\netstandard2.0\LineEditor.xml</DocumentationFile>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DocumentationFile>bin\Release\netstandard2.0\LineEditor.xml</DocumentationFile>
</PropertyGroup>

</Project>

0 comments on commit 5d67d34

Please sign in to comment.