-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkiaSharp.Views.Forms.WPF nuget Package does not work out of the Box #1011
Comments
Ah, I think you may actually be wanting to use SkiaSharp.Views.WPF. Note the lack of the Unless you are using Xamarin.Forms and then I have a dodgy package. |
I see what you mean. I created a new project and I see what you are talking about. Let me find a fix |
Yes you are right, I meant a Xamarin.Forms WPF Application. |
Thanks for reporting this issue. I got it fixed and it will be in the next preview release. |
I am pushing a NuGet now. rc.170 should be up soon and you can test. |
I tested it and the SkiaSharp.Views.Forms.Wpf works like a charm, thanks a lot. I tested if the UWP and the Android Version work too and they seemed fine. For me it seems that in the x64 android compilation something went wrong. I reverted back to 1.68 and the colors looked perfect in the emulator. |
@inforithmics Could you open a new issue on this? I want to make sure that I fix any issues before we release. I don't think I changed anything for Android, but I can check. Also could you attach some screenshots/sample code that generates this? |
I created a new issue: #1017 |
Thanks! I will investigate. |
Description
https://www.nuget.org/packages/SkiaSharp.Views.Forms.WPF/1.68.1-rc.169 does not work out of the box. The Xamarin WPF Application crashes with an SKCanvasViewRenderer does not implement IRegistrable
Code
<PackageReference Include="SkiaSharp.Views.Forms.WPF" Version="1.68.1-rc.169" />
Expected Behavior
Xamarin WPF Application works without issues.
Actual Behavior
Xamarin WPF Application with Skiasharp crashes.
Basic Information
Screenshots
None
Reproduction Link
None
Workaround
Adding this Package Reference fixed it for me.
Because during compilation it took the dll from SkiaSharp.Views.Forms
instead of SkiaSharp.Views.Forms.WPF.
I think the error is that SkiaSharp.Views.Forms.WPF has a dependency on SkiaSharp.Views.Forms. (which it shouldn't have because both
SkiaSharp.Views.Forms.WPF
and
SkiaSharp.Views.Forms provide SkiaSharp.Views.Forms.dll).
And nuget decides in my case to use the SkiaSharp.Views.Forms nuget package dll which does not work on WPF.
The text was updated successfully, but these errors were encountered: