Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove the non-supported platforms from the runtimes folder #1301

Closed
mattleibow opened this issue May 19, 2020 · 1 comment · Fixed by #1366
Closed

[FEATURE] Remove the non-supported platforms from the runtimes folder #1301

mattleibow opened this issue May 19, 2020 · 1 comment · Fixed by #1366

Comments

@mattleibow
Copy link
Contributor

When doing a dotnet publish on a .NET Core app (for example a console app), the output folder will have all the supported platforms in the output.

For now, it is a bit annoying, but once #1296 lands, it will literally have all the platforms there. So, when publishing an ASP.NET Core website, it will have the libSkiaSharp.framework there too. It is a nice thought that we can all can run our websites from our iPhones, but not realistic. The games will be glitchy when the world hits our local blog... anyways. 😆

Since I control the NuGet package... I can actually investigate removing the unsupported platforms. I already do this in part for Tizen (which is .NET Core). When publishing a netcoreapp3.0, I can skip all the runtimes for mobile.

What are your thoughts and reasons around this type of inclusion/exclusion of the native runtimes? What are you doing now? What do you want the NuGets to just do for you?

@mattleibow
Copy link
Contributor Author

Thinking about this some more and I think it might be nice to split the native assets into separate packages now that all the bits are .targets-based. And, this will allow for improved/reduced .targets files.

One of the issue is that Tizen uses the "linux-armel" runtimes folder, which is a valid item for other things. Splitting this into a separate Tizen package that only installs on Tizen means no scripts needed at all.

But, not just that, my previous decision to include the .framework and .so files for iOS and Android in the runtimes folder is a bit premature. This is only going to be useful for .NET 6 and that is a year away.

I want to get at least a stable version of v2.80 out next week (if all is well), so this will have to wait for v2.80.1 - which will hopefully be soon after.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant