Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open last edited file on start #85

Closed
pq opened this issue May 24, 2018 · 7 comments
Closed

open last edited file on start #85

pq opened this issue May 24, 2018 · 7 comments
Labels
enhancement New feature or request polish

Comments

@pq
Copy link
Collaborator

pq commented May 24, 2018

maybe derived from system.lua?

EDIT: current plan is to open last edited file, potentially gated by routable URLs (#70)

@pq pq added the enhancement New feature or request label May 24, 2018
@artfwo
Copy link
Member

artfwo commented May 24, 2018

why not last script edited?

@pq
Copy link
Collaborator Author

pq commented May 24, 2018

right. i guess i'd expect that, unless there's a script running on the device, in which case i suppose i'd want that.

honestly, either is fine. some state awareness would be nice.

@pq
Copy link
Collaborator Author

pq commented May 24, 2018

@ngwese, @jlmitch5, @tehn : curious if you have any thoughts?

@jlmitch5
Copy link
Collaborator

I think I would probably lean towards last script edited. For example, if you refresh Maiden, you'd probably expect it to be at the same place.

I also think this would probably best be solved with setting up routing. In other words, editing script foo.lua would lead to the url: http://localhost:3001/#/scripts/foo.lua or something like that.

@ngwese
Copy link
Member

ngwese commented May 24, 2018

i think "last script edited" fits the increasingly common model of an editor coming back up in the last state it was left in. in that regard the maiden code base is well situated to achieve this given that all the state is neatly captured in the redux store.

...i had been imagining some logic write the complete state back to norns periodically and/or at certain strategic user interaction points.

@jlmitch5 there is another ticket from @artfwo about having routable URLs #70

@pq pq changed the title consider having maiden open w/ the last script run open last edited file on start May 24, 2018
@pq
Copy link
Collaborator Author

pq commented May 24, 2018

nice. agreed on all points above. title changed to reflect new direction. 👍

@pq pq added the polish label May 25, 2018
@ryanlaws
Copy link
Contributor

I have a potential fix for this - #167

@ngwese ngwese closed this as completed in 7c2440e Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request polish
Projects
None yet
Development

No branches or pull requests

5 participants