Include the BBB Mock container #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
requested changes
Dec 9, 2022
There was a problem hiding this comment.
Hi,
it looks nearly ok. But the BBBMOCK used in the config.php template does not exist.
Because of that, and following a similar path used for other env variables, I've suggested to create the env variable (with the same name) in the new yml file and then just read it.
andrewnicols
force-pushed
the
bbbmock
branch
from
fc7d87c
to
4675228
Compare
andrewnicols
force-pushed
the
bbbmock
branch
from
4675228
to
83121cb
Compare
andrewnicols
force-pushed
the
bbbmock
branch
from
83121cb
to
5ed8ba6
Compare
|
Suggested changes have been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.