-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the commit history browsing performances #45
Comments
I'm also suffering from But I'm wondering whether really
but nyx/modules/go/nyx/command/infer.go Line 227 in 96d0815
for the CLI tool. Anyway, I believe the problem could be rather the algorithm. Instead of walking all history (as it seems), wouldn't it make more sense to determine only the latest tag (if any) on the current branch, any only from there walk up the history to determine the version increment based on conventional commits? |
Hi @sschuberth , it's very likely, as you say, the issue is in the algorithm and ideas are welcome, considering that:
When I first noticed this issue I only had the Java implementation, no Go yet, so Java is affected for sure. Nonetheless, as you pointed out, the issue is the algorithm, regardless the language. |
For testing, I was trying Git.SemVersioning.Gradle on the same project, which was much faster. Maybe we could borrow some ideas from https://github.com/jmongard/Git.SemVersioning.Gradle/blob/master/src/main/kotlin/git/semver/plugin/semver/VersionFinder.kt? |
And for the Go version, maybe compare with https://github.com/PSanetra/git-semver. |
Method
JGitRepository.walkHistory()
is slow and thatàs probably due to the retrieval of all tags for each commit.Its performances must be improved.
The text was updated successfully, but these errors were encountered: