Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Handle 422 response #58

Closed
jdenen opened this issue Apr 22, 2017 · 1 comment
Closed

Handle 422 response #58

jdenen opened this issue Apr 22, 2017 · 1 comment
Assignees
@jdenen
Labels
help wanted internals
Milestone
1.0.0

Comments

@jdenen
Copy link
Collaborator

jdenen commented Apr 22, 2017 •
edited
Loading

You can't favourite an already favourited toot. You get a 422 response. We should handle this gracefully instead of popping the failed response buffer. Options:

  1. Message feedback that says something like Already favourited #12345
  2. Make favourite function a toggle between favourite/unfavourite

Fix should be applied to the boost function too.
@jdenen jdenen added this to the 1.0.0 milestone Apr 22, 2017
@jdenen
Copy link
Collaborator Author

jdenen commented Apr 22, 2017

Spun off of #55

@jdenen jdenen mentioned this issue Apr 26, 2017
Merged
@ghost ghost assigned jdenen Apr 26, 2017
@ghost ghost added review and removed ready labels Apr 26, 2017
@jdenen jdenen closed this as completed Apr 27, 2017
@ghost ghost removed the review label Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jdenen jdenen

Labels
help wanted internals
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@jdenen