-
Notifications
You must be signed in to change notification settings - Fork 512
Olmo's workflow
ibolmo edited this page Nov 29, 2011
·
4 revisions
- Find an issue.
-
git fetch mootools
1 to get any new changes to master -
git checkout -b [action]-[issue#]-[description-delimited-by-dash]
e.g.git checkout -b fix-1000-ie-button-type-throws
- repeat 2-3 for any submodules
- if necessary, add specs to reproduce failure
- work on the fix 2
- run the specs 3 until all browsers pass
-
git add [files]
orgit commit -a
if modified already present files - write a good commit message 4
-
git push [your-git-repo] [action]-[issue#]-[description-delimited-by-dash]
(tip: use tab completion for topic branch) - go to your github repo page
- select your topic branch
- send pull request. optionally modify subject and description of pull request.
- done, or start over at 1.
Use ./developers.sh
to get your favorite MooTools developers added to your known git remote
repos.
-
Stick to what you need to fix. If you find something else that needs to be fixed or cleaned, create an issue or create another topic branch.
-
If you're going to fix it with something controversial or something you're unsure of, then commit early and send a pull request with description and with @requests to notify developers.
General pattern
<action>
<empty line>
<description>
<empty line>
<spec results>
Use active voice to explain what you did. Examples: Fixes, Improves, Removes. Include issue # if appropriate. Fixes #2100.
Add as much relevant information as necessary: what, why, how, where.
General pattern
<RESULT>: <browser> <browser-version>; ...
...
Example: PASSED: FFx 3-5, 8, 10; IE6-9, Safari 5
Working Example:
Fixes #2118.
Noticed that there's no $uid dependency in Browser.js. Moved $uid and
$uid calls for window and document to Element.js.
PASSED: IE6-9, FFx 3-5, 8, 10, Chrome latest, Safari 5, Opera 11