server: validate file endpoint should return 400, not 500 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
force-pushed
the
validate-4xx
branch
from
d85ab48
to
585255d
Compare
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
+ Coverage 85.22% 85.68% +0.46%
==========================================
Files 111 111
Lines 6558 6561 +3
==========================================
+ Hits 5589 5622 +33
+ Misses 674 642 -32
- Partials 295 297 +2 |
500's represent internal errors (bugs), but 400 is more fitting here. It also looks like other endpoints here return 5xx errors that might confuse people later on, so this is showing how we could fixup those.
adamdecaf
force-pushed
the
validate-4xx
branch
from
585255d
to
779adee
Compare
bkmoovio
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
500's represent internal errors (bugs), but 400 is more fitting
here. It also looks like other endpoints here return 5xx errors that
might confuse people later on, so this is showing how we could fixup those.
See: https://github.com/moov-io/api/pull/71