Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

Album artist id's are wrong #215

Closed
sebsebmc opened this issue May 2, 2019 · 3 comments
Closed

Album artist id's are wrong #215

sebsebmc opened this issue May 2, 2019 · 3 comments

Comments

@sebsebmc
Copy link

sebsebmc commented May 2, 2019

When searching, albums will return their artists as the md5 of the artist name, not the artist ID that is returned from gmusicapi.

artist = self._aa_search_artist_album_to_mopidy_artist_album(album)

I have a fix in my commit sebsebmc/mopidy-gmusic@2a081de, but I don't know why the artist ID wasn't used in the first place.

I haven't cleaned up the code yet but if this is the right fix I can clean up the code and submit a pull request.

@jjok
Copy link
Contributor

jjok commented Mar 12, 2020

I think this should no longer be an issue since #233 has been merged, although I haven't specifically heard from anyone with a subscription who has tried those changes.

@sebsebmc
Copy link
Author

This actually creates the issue that the new id's don't match what the gmusic API uses and means that if you try and library browse a gmusic:artist:artist_id using the returned id it will not work.

Basically if I search and get an artist id I cannot use that artist id to browse that artist anymore if I were to use your fix.

@jodal
Copy link
Member

jodal commented Dec 6, 2020

Closing because Google Play Music has been shut down, and this project is being discontinued.

@jodal jodal closed this as completed Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants