Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A proper home for find_mtimes() #19

Closed
jodal opened this issue Dec 9, 2019 · 1 comment
Closed

A proper home for find_mtimes() #19

jodal opened this issue Dec 9, 2019 · 1 comment
Milestone

Comments

@jodal
Copy link
Member

jodal commented Dec 9, 2019

[Moved from PR comment in #10.]

In Mopidy, mopidy.internal.path.find_times() is now a reexport of mopidy.internal.mtimes.find_times(). It is only used by tests/audio/test_scan.py. I think that we should either:

  • conclude that the mopidy.internal.mtimes module belongs in Mopidy-Local and not Mopidy, or
  • make find_times() a public method, maybe in the mopidy.audio.scan module?

@adamcik Any thoughts on the placement of the scanner and its supporting functions?

@adamcik
Copy link
Member

adamcik commented Dec 9, 2019

I would err towards moving out. The find time stuff is all done for local's scanner at least, while I think the scanner might be used by e.g. the stream backend? If so we need to keep at least some of it mopidy.

@jodal jodal closed this as completed in 29db431 Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants