Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with Jest #1

Open
morajabi opened this issue Jul 9, 2017 · 9 comments
Open

Add tests with Jest #1

morajabi opened this issue Jul 9, 2017 · 9 comments
Labels

Comments

@morajabi
Copy link
Owner

morajabi commented Jul 9, 2017

No description provided.

@brajabi
Copy link
Collaborator

brajabi commented Jul 9, 2017

Maybe I can take this? @morajabi Why did you choose Jest?

@morajabi
Copy link
Owner Author

morajabi commented Jul 9, 2017

Great! I think Jest is simplest method with awesome features out-of-the-box! If you have any questions mention me.

@timhagn
Copy link
Collaborator

timhagn commented Oct 26, 2018

Hope, I haven't stepped on anyone's toes, but I just went ahead and started writing the tests.
@morajabi Maybe you could merge my first PR ahead of them, so you could "test" if your build
workflow with rollup is really still working with npm.
Had to add react & react-dom (same versions as in styled-components, speaking newest 16.6.0)
to devDependencies for the tests to run.

@morajabi
Copy link
Owner Author

@timhagn No, you haven't stepped on anyone's toes! 😄🙌

@timhagn
Copy link
Collaborator

timhagn commented Oct 26, 2018

@morajabi Puh, now I'm relieved ^^. Just thought, because @brajabi wanted to do this in July, there might be a conflict of interest ; ).

@timhagn
Copy link
Collaborator

timhagn commented Mar 6, 2019

Is this and my PR #15 stale or still welcome? Also, how shall it interact and be merged with #16 pertaining #3? Questions above questions ^^.

@morajabi
Copy link
Owner Author

morajabi commented Mar 7, 2019

@timhagn Surely welcome, why not? I'm not sure, should we merge #15 first or #16?

@timhagn
Copy link
Collaborator

timhagn commented Mar 8, 2019

Hi @morajabi,

though I'm quite new to TypeScript, I like the work @franky47 put into #16.
But as was pointed out in the first comment of PR #16 maybe #15 should be merged first, methinks.

What do the others think?

(And I just asked if this issue / #15 were now stale, cause of the time lag ; ).

@timhagn
Copy link
Collaborator

timhagn commented Oct 25, 2019

Opened a new PR #19 with updated tests bringing them to 100% coverage : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants