Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message when withdrawing too much #60

Closed
MerlinEgalite opened this issue Sep 13, 2023 · 0 comments · Fixed by #63
Closed

Error message when withdrawing too much #60

MerlinEgalite opened this issue Sep 13, 2023 · 0 comments · Fixed by #63
Assignees
@Rubilmax

Comments

@MerlinEgalite
Copy link
Contributor

MerlinEgalite commented Sep 13, 2023 •
edited
Loading

When withdrawing too much, 2 errors can be raised depending on how much is withdrawn:

  • withdraw order failed
  • ERC20: burn amount exceeds balance

We should harmonize this behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(vault): rewrite _deposit & _withdraw morpho-org/metamorpho
2 participants
@Rubilmax @MerlinEgalite