Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where should we place oracles? #157

Closed
MerlinEgalite opened this issue Jul 21, 2023 · 11 comments
Closed

Where should we place oracles? #157

MerlinEgalite opened this issue Jul 21, 2023 · 11 comments
Labels

Comments

@MerlinEgalite
Copy link
Contributor

Should we create an extension folder, an oracle folder?

@QGarchery
Copy link
Contributor

We could imagine having multiple libraries to help integrations, with for example:

All of those could be regrouped in a lens/utils/external-lib folder, and then we would have one oracle folder and one irm folder, both of which would be using the lens folder (or whatever we choose).

I feel like the most important point though is to be able to distinguish between the core protocol and what will be built on top (including what is needed to create a market). So I would be in favor of placing everything in a separate extension folder, and everything we have now under src in a blue folder

@MerlinEgalite
Copy link
Contributor Author

I think we should keep the src folder just for consistency with other repositories but overall I agree we should make a distinction between both the core protocol and the extensions.

@MathisGD
Copy link
Contributor

Yo me they should not be in this repo but in a periphery repo

@MerlinEgalite
Copy link
Contributor Author

MerlinEgalite commented Jul 22, 2023

we have a morpho-blue-periphery repo with MetaMorpho's related code, do you think we should group them together?

@MathisGD
Copy link
Contributor

You mean repo not contract right ? Yes it can be an idea

@MerlinEgalite
Copy link
Contributor Author

yes sorry updated. But in my mind oracles is closer to the core protocol than MM..

@MerlinEgalite
Copy link
Contributor Author

For now what I propose it that we put them in this repo and then we move then later in another repo. It would ease discussions and speed up implementation.

@MathisGD
Copy link
Contributor

in the test folder then, not src

@MathisGD
Copy link
Contributor

Closing for now

@MerlinEgalite
Copy link
Contributor Author

Reopening else we lose the discussion

@MerlinEgalite
Copy link
Contributor Author

We put all of them in periphery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants