Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive failing with annotation #8

Closed
ReedOnly opened this issue Oct 23, 2019 · 5 comments
Closed

Revive failing with annotation #8

ReedOnly opened this issue Oct 23, 2019 · 5 comments

Comments

@ReedOnly
Copy link

With annotation turned on the Docker container fails and it seems like revive crashes.

Any idea?

revive

@morphy2k
Copy link
Owner

Can you send me the log of the workflow run?

@ReedOnly
Copy link
Author

2019-10-23T11:57:55.3761411Z ##[group]Run docker://morphy/revive-action:v1
2019-10-23T11:57:55.3761526Z with:
2019-10-23T11:57:55.3761607Z   config: .github/revive_config.toml
2019-10-23T11:57:55.3761691Z   path: api/...
2019-10-23T11:57:55.3761771Z env:
2019-10-23T11:57:55.3761930Z   GITHUB_TOKEN: ***
2019-10-23T11:57:55.3762012Z ##[endgroup]

2019-10-23T11:57:55.4029700Z ##[command]/usr/bin/docker run --name morphyreviveactionv1_d35cb7 --label fbc64f --workdir /github/workspace --rm -e GITHUB_TOKEN -e INPUT_CONFIG -e INPUT_PATH -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/seismic-cloud/seismic-cloud":"/github/workspace" morphy/revive-action:v1

2019-10-23T11:57:59.7564922Z Successful run with 25 failures (25 warnings, 0 errors)
2019-10-23T11:58:00.1401914Z ##[error]Docker run failed with exit code 1
2019-10-23T11:58:00.1504441Z Cleaning up orphan processes

@morphy2k
Copy link
Owner

The annotations are displayed? If failures are found, this is the normal behavior.
Maybe I should rethink this.

@ReedOnly
Copy link
Author

ReedOnly commented Nov 6, 2019

No, annotations are not displayed, that's the problem, and docker container fails even when there should only be warnings...

@morphy2k
Copy link
Owner

The issue should be fixed with the latest release (v1.3). The annotation tool exited with code 1 on every failure regardless of severity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants