-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover refactor (work in progress) #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto html-hover Conflicts: lib/morris.bar.coffee morris.js morris.min.js
Conflicts: morris.min.js
Conflicts: lib/morris.line.coffee morris.js morris.min.js
- Morris.Hover now encapsulates the hover object, with no graph-specific code. - Tests for Morris.Hover. - Add chai-jquery to test suite.
This was referenced Dec 9, 2012
ghost
assigned oesmith
Dec 9, 2012
This was referenced Dec 9, 2012
Closed
OK, this is pretty much all done now, except documentation. Since the docs are going to go on the gh-pages branch (and won't be published until the v0.4.0 release), I'm merging this PR into master now. |
oesmith
added a commit
that referenced
this pull request
Dec 19, 2012
Hover refactor (work in progress)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the existing hover box to be an HTML element instead of a Raphael one.
Also add: