From 29ac338ff0c340d5a0a65e2d05b6ef368676d99e Mon Sep 17 00:00:00 2001 From: root <23239305+b-chu@users.noreply.github.com> Date: Thu, 25 Jan 2024 22:31:58 +0000 Subject: [PATCH 1/3] Add checkpoint test for 0.18.1 --- tests/trainer/test_fsdp_checkpoint.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/trainer/test_fsdp_checkpoint.py b/tests/trainer/test_fsdp_checkpoint.py index 0799d815d4..7ba3db5d10 100644 --- a/tests/trainer/test_fsdp_checkpoint.py +++ b/tests/trainer/test_fsdp_checkpoint.py @@ -401,7 +401,12 @@ def test_fsdp_mixed_with_sync( '0.17.0', marks=pytest.mark.filterwarnings((r'ignore:MosaicMLLogger is not in the state_dict. Its ' r'state will not be restored.:UserWarning')), - ) + ), + pytest.param( + '0.18.1', + marks=pytest.mark.filterwarnings((r'ignore:MosaicMLLogger is not in the state_dict. Its ' + r'state will not be restored.:UserWarning')), + ), ]) @pytest.mark.filterwarnings(r'ignore:.*metrics are not saved with sharded state dict.*:UserWarning') @pytest.mark.filterwarnings(r'ignore:.*The CUDA RNG state could not be loaded.*:UserWarning') From c2f905804073263ef712b0dab22b42426beb1212 Mon Sep 17 00:00:00 2001 From: Brian <23239305+b-chu@users.noreply.github.com> Date: Fri, 26 Jan 2024 09:22:31 -0500 Subject: [PATCH 2/3] Remove mark for test --- tests/trainer/test_fsdp_checkpoint.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/trainer/test_fsdp_checkpoint.py b/tests/trainer/test_fsdp_checkpoint.py index 7ba3db5d10..fa160c3675 100644 --- a/tests/trainer/test_fsdp_checkpoint.py +++ b/tests/trainer/test_fsdp_checkpoint.py @@ -402,11 +402,7 @@ def test_fsdp_mixed_with_sync( marks=pytest.mark.filterwarnings((r'ignore:MosaicMLLogger is not in the state_dict. Its ' r'state will not be restored.:UserWarning')), ), - pytest.param( - '0.18.1', - marks=pytest.mark.filterwarnings((r'ignore:MosaicMLLogger is not in the state_dict. Its ' - r'state will not be restored.:UserWarning')), - ), + pytest.param('0.18.1'), ]) @pytest.mark.filterwarnings(r'ignore:.*metrics are not saved with sharded state dict.*:UserWarning') @pytest.mark.filterwarnings(r'ignore:.*The CUDA RNG state could not be loaded.*:UserWarning') From b8fcc1ee4f058b5d7d16f4535d26d2d15c7b27c9 Mon Sep 17 00:00:00 2001 From: Brian <23239305+b-chu@users.noreply.github.com> Date: Mon, 29 Jan 2024 11:29:47 -0500 Subject: [PATCH 3/3] Remove param --- tests/trainer/test_fsdp_checkpoint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/trainer/test_fsdp_checkpoint.py b/tests/trainer/test_fsdp_checkpoint.py index fa160c3675..77cb3f9b93 100644 --- a/tests/trainer/test_fsdp_checkpoint.py +++ b/tests/trainer/test_fsdp_checkpoint.py @@ -402,7 +402,7 @@ def test_fsdp_mixed_with_sync( marks=pytest.mark.filterwarnings((r'ignore:MosaicMLLogger is not in the state_dict. Its ' r'state will not be restored.:UserWarning')), ), - pytest.param('0.18.1'), + '0.18.1', ]) @pytest.mark.filterwarnings(r'ignore:.*metrics are not saved with sharded state dict.*:UserWarning') @pytest.mark.filterwarnings(r'ignore:.*The CUDA RNG state could not be loaded.*:UserWarning')