-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate GOMC and CHARMM writer #1064
Conversation
This pull request fixes 11 alerts when merging d535ea4 into 846e18e - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine with me as long as it passes all the tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 90.56% 90.69% +0.13%
==========================================
Files 60 57 -3
Lines 8406 5397 -3009
==========================================
- Hits 7613 4895 -2718
+ Misses 793 502 -291 ☔ View full report in Codecov by Sentry. |
This pull request fixes 11 alerts when merging 52c3988 into 671572f - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Note to self: need to refer to this https://github.com/mosdef-hub/mbuild/pull/1029/files for other changes that could be removed. |
This pull request fixes 11 alerts when merging 9fcfb71 into 671572f - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request fixes 12 alerts when merging d1031b2 into 671572f - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
PR Summary:
Now that https://github.com/GOMC-WSU/MoSDeF-GOMC is in decent shape. I think it's time to migrate the CHARMM and GOMC writers that initially added here by @bc118.
PR Checklist