Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off fail-fast #1067

Merged
merged 8 commits into from
Dec 13, 2022
Merged

Turn off fail-fast #1067

merged 8 commits into from
Dec 13, 2022

Conversation

daico007
Copy link
Member

@daico007 daico007 commented Dec 6, 2022

PR Summary:

Right now, if what of the check failed, all the other unfinished checks will get canceled, which miss the point of testing on different OS. This PR turns that off.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (8e48eb4) to head (47d3811).
Report is 138 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1067      +/-   ##
==========================================
- Coverage   90.49%   86.08%   -4.42%     
==========================================
  Files          61       61              
  Lines        6157     6157              
==========================================
- Hits         5572     5300     -272     
- Misses        585      857     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@CalCraven CalCraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick patch. We can discuss about what could be the cause of this issue for windows at a later time.

Copy link
Contributor

@bc118 bc118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked one required change. I can not test the windows build, so I count on someone else or the autotests for the PRs.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bc118 bc118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked one required change. I can not test the windows build, so I count on someone else or the autotests for the PRs. As long as the docs are building it should be OK.

@daico007 daico007 merged commit 5388e28 into mosdef-hub:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants