-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing energy minimization tests #1076
Conversation
The issue with the energy minimization tests seems related to converting the list of constraints to numpy arrays, in order to get their shape. Specifying "dtype=object" when converting to an np array fixes the issues. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
===========================================
+ Coverage 78.21% 90.49% +12.28%
===========================================
Files 57 61 +4
Lines 5513 6157 +644
===========================================
+ Hits 4312 5572 +1260
+ Misses 1201 585 -616 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Summary:
energy minimization checks are now failing on ubuntu. This PR is focused on trying to identify the issue.
PR Checklist