Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This addresses issue #1125 whereby the freud_generate_bonds routine was not finding all bonds when looking for bonds between two different species
As detailed in the issue, this was caused by the way in which we pass the particles to freud during the calculation of neighbors. Ultimately, the fix for this is relatively straight forward to implement. If name_a == name_b, then exclude_ii = True; If name_a != name_b, then exclude_ii = False. This is now automatically toggled by the code, and users no longer have the option to change this.
An additional test is included now that looks at a system where the two specifies are unique, as the original tests did not include this.
PR Checklist