Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option for packing.solvate #1144

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

daico007
Copy link
Member

@daico007 daico007 commented Aug 30, 2023

PR Summary:

Add option to (not) center the solute in mb.packing.solvate, will address #974. Pending unit test.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d94cc3a) 87.12% compared to head (d4b4259) 87.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   87.12%   87.13%           
=======================================
  Files          62       62           
  Lines        6455     6457    +2     
=======================================
+ Hits         5624     5626    +2     
  Misses        831      831           
Files Coverage Δ
mbuild/packing.py 95.28% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@CalCraven CalCraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mbuild/packing.py Outdated Show resolved Hide resolved
daico007 and others added 2 commits September 26, 2023 10:53
Co-authored-by: CalCraven <54594941+CalCraven@users.noreply.github.com>
@daico007 daico007 merged commit 1cf9df9 into mosdef-hub:main Sep 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants