Add check_box_size
option for add
method in Compound.add()
#1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Add
verbose
option foradd
method inCompound.add()
. When provided a list of compound toCompound
, the method would recursively calling itself to add each compound. During this process, there is a final step to check if the new compound bounding box is bigger than theCompound.Box
. The time forCompound.get_boundingbox()
, however, would really add up in this process (scale up really badly if you get to the >10,000 range). Hence, I am adding anverbose
option for this method to be able to turn it off when adding individual particle if a list/iterable is provided.PR Checklist