Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing doc build #1177

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix failing doc build #1177

merged 3 commits into from
Mar 26, 2024

Conversation

daico007
Copy link
Member

PR Summary:

Turn out, even though the docs build on readthedocs pass, some of the pages still failed to be built (but didn't error out). This PR will try to fix the remaining issue with the docs and addressed the issue raised in #1174.

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (d9a9498) to head (7c5708d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files          62       62           
  Lines        6502     6502           
=======================================
  Hits         5675     5675           
  Misses        827      827           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daico007 daico007 merged commit dac6730 into mosdef-hub:main Mar 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants