Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests with latest version of packmol #1189

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

CalCraven
Copy link
Contributor

Update packmol arguments to raise Errors on overlapping molecules on overpacked boxes, and reduce overlaps argument for test cases.

PR Summary:

PR Checklist


  • Includes appropriate unit test(s)
  • Appropriate docstring(s) are added/updated
  • Code is (approximately) PEP8 compliant
  • Issue(s) raised/addressed?

Copy link
Contributor

@chrisjonesBSU chrisjonesBSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chrisjonesBSU
Copy link
Contributor

The windows version of PACKMOL on conda-forge is very out-dated, so at some point if the differences of released versions become too large, we might not be able to support both in the CI workflow. This came up as a problem in #787

@daico007
Copy link
Member

daico007 commented Jun 3, 2024

should we scrap the windows CI?

@chrisjonesBSU
Copy link
Contributor

should we scrap the windows CI?

IMO, I think we should.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (2bb047e) to head (db6334d).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   87.32%   87.41%   +0.09%     
==========================================
  Files          62       62              
  Lines        6525     6540      +15     
==========================================
+ Hits         5698     5717      +19     
+ Misses        827      823       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daico007 daico007 merged commit 2d16145 into mosdef-hub:main Jun 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants