Add Ruff to pre-commit hooks #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| element_list = [ | ||
| c.element for c in container.particles_by_element("sod") | ||
| ] | ||
| element_list = [c.element for c in container.particles_by_element("sod")] |
Check notice
Code scanning / CodeQL
Unused local variable Note test
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 85.73% 85.68% -0.06%
==========================================
Files 53 53
Lines 4802 4791 -11
==========================================
- Hits 4117 4105 -12
- Misses 685 686 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
CalCraven
approved these changes
Nov 22, 2024
CalCraven
pushed a commit
to CalCraven/mbuild
that referenced
this pull request
Nov 22, 2024
* update CI and precommit files * add ruff changes * remove gmso lines * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * change error type in test * raise the error that is created * remove duplicate windows 3.12 test * fix precommit errors * fix import error * fix CI error --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
This adds Ruff to the pre-commit hooks, like we did in GMSO and foyer
Closes #1186
PR Checklist