Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lizard exclude parameter being generated incorrectly by the plugin #41

Closed
Unknoob opened this issue Feb 12, 2020 · 1 comment
Closed

Comments

@Unknoob
Copy link
Collaborator

Unknoob commented Feb 12, 2020

I tried to set a exclude parameter with multiple patterns but the plugin is incorrectly generating the command so lizard ignores the patterns.

Here's the plugin call on fastlane

lizard(
      source_folder: ".", 
      exclude: "./Folder1/Subfolder1/*, ./Folder2/*",
      language: "swift", 
      export_type: "xml", 
      report_file: "sonar-reports/lizard-report.xml"
    )

The command generated is:
lizard -l swift --xml -x ./Folder1/Subfolder1/* -x ./Folder2/* . > sonar-reports/lizard-report.xml

But according to lizard documentation it should be:
lizard -l swift --xml -x "./Folder1/Subfolder1/*" -x "./Folder2/*": . > sonar-reports/lizard-report.xml

Reference: https://github.com/terryyin/lizard/blob/master/README.rst
Don't forget to add "" around the pattern.

@mosesliao
Copy link
Owner

@Unknoob thank you for your contribution. I have approved and merged your fix.

You are now added as a collaborator for this plugin. Once again thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants